feat(linux): add support on Linux for JDK 25 preview in Docker build configurations #549
+46
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add JDK25 version variable (25+9-ea-beta) to docker-bake.hcl - Update jlink configuration for JDK25 with specific modules - Create separate Windows JDK build matrix excluding JDK25 - Support JDK25 on Alpine and Debian Linux platforms only
lemeurherve
reviewed
Oct 5, 2025
Comment on lines
+51
to
+53
| # JDK 25 switches to a minimal module set for smaller images. Override with JLINK_MODULES to restore broader compatibility if needed. | ||
| "25"*) mod_list="${JLINK_MODULES:-java.base,java.logging,java.xml,java.management,java.net.http,jdk.crypto.ec}"; \ | ||
| set -- "--compress=zip-6" --add-modules "$mod_list" ;; \ |
There was a problem hiding this comment.
Suggested change
| # JDK 25 switches to a minimal module set for smaller images. Override with JLINK_MODULES to restore broader compatibility if needed. | |
| "25"*) mod_list="${JLINK_MODULES:-java.base,java.logging,java.xml,java.management,java.net.http,jdk.crypto.ec}"; \ | |
| set -- "--compress=zip-6" --add-modules "$mod_list" ;; \ | |
| # JDK 25 switches to a minimal module set for smaller images | |
| "25"*) set -- "--compress=zip-6" --add-modules "java.base,java.logging,java.xml,java.management,java.net.http,jdk.crypto.ec" ;; \ |
Let's keep in simple for now like what's in the docker-agent which already has JDK25 images.
Comment on lines
+46
to
+47
| ARG JLINK_MODULES | ||
|
|
There was a problem hiding this comment.
Suggested change
| ARG JLINK_MODULES |
See above
Comment on lines
+45
to
+46
| ARG JLINK_MODULES | ||
|
|
There was a problem hiding this comment.
Suggested change
| ARG JLINK_MODULES |
ditto
Comment on lines
+53
to
+55
| # JDK 25 switches to a minimal module set for smaller images. Override with JLINK_MODULES to restore broader compatibility if needed. | ||
| "25"*) mod_list="${JLINK_MODULES:-java.base,java.logging,java.xml,java.management,java.net.http,jdk.crypto.ec}"; \ | ||
| set -- "--compress=zip-6" --add-modules "$mod_list" ;; \ |
There was a problem hiding this comment.
Suggested change
| # JDK 25 switches to a minimal module set for smaller images. Override with JLINK_MODULES to restore broader compatibility if needed. | |
| "25"*) mod_list="${JLINK_MODULES:-java.base,java.logging,java.xml,java.management,java.net.http,jdk.crypto.ec}"; \ | |
| set -- "--compress=zip-6" --add-modules "$mod_list" ;; \ | |
| # JDK 25 switches to a minimal module set for smaller images | |
| "25"*) set -- "--compress=zip-6" --add-modules "java.base,java.logging,java.xml,java.management,java.net.http,jdk.crypto.ec" ;; \ |
ditto
| } | ||
|
|
||
| variable "JAVA25_VERSION" { | ||
| default = "25+9-ea-beta" |
There was a problem hiding this comment.
Suggested change
| default = "25+9-ea-beta" | |
| default = "25_36" |
Let's directly use the GA version and skip the EA beta altogether.
Could you rename your PR if you accept this suggestion please?
feat: add JDK25 Linux images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done
make buildSubmitter checklist